chore(core): bump nostr-lock mainnet cell deps #354
Conversation
🦋 Changeset detectedLatest commit: 5af67a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for liveccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for apiccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @RetricSu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Deploy Preview for docsccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the txHash for the nostr-lock mainnet script dependency. The change itself is correct according to the PR description. I've added one comment to improve code maintainability by suggesting the addition of a comment that explains the origin of this new hash, which will be helpful for future reference.
| outPoint: { | ||
| txHash: | ||
| "0x1911208b136957d5f7c1708a8835edfe8ae1d02700d5cb2c3a6aacf4d5906306", | ||
| "0x99b116dd1e4f1fa903b70112ae672c18bb34241d3d03a9ad555cd2a611be7327", |
There was a problem hiding this comment.
For better long-term maintainability, it's helpful to add a comment explaining the origin of this transaction hash. The pull request description provides valuable context about the new deployment, and capturing this information in the code will help developers in the future understand where this value comes from without needing to search through git history.
| "0x99b116dd1e4f1fa903b70112ae672c18bb34241d3d03a9ad555cd2a611be7327", | |
| "0x99b116dd1e4f1fa903b70112ae672c18bb34241d3d03a9ad555cd2a611be7327", // From nostr-binding@eef134e |
✅ Deploy Preview for appccc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
RetricSu
force-pushed
the
bump-nostr-lock-config
branch
from
8aa48e8 to
9018c78
Compare
Hanssen0
left a comment
Hanssen0
left a comment
There was a problem hiding this comment.
LGTM. Please change the changeset level to patch and rebase this PR to the release branch.
RetricSu
force-pushed
the
bump-nostr-lock-config
branch
from
9018c78 to
5af67a2
Compare
|
Thank you for your contribution! |
2 participants
A new mainnet deployment on nostr-lock script has been taking effect to upgrade multisig signers. No contract code changes in this deployment.
This PR bumps the nostr-lock mainnet config in
ckb-ccc/corepackage. More details about the deployment can be found here: