feat(core): multisig Signers

[Hanssen0]

• I have read the Contributing Guidelines

This PR should be reviewed one by one according to the commits.

[changeset-bot]

🦋 Changeset detected

Latest commit: a137473

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages

Name	Type
@ckb-ccc/core	Minor
@ckb-ccc/did-ckb	Patch
@ckb-ccc/eip6963	Patch
@ckb-ccc/joy-id	Patch
@ckb-ccc/lumos-patches	Patch
@ckb-ccc/nip07	Patch
@ckb-ccc/okx	Patch
@ckb-ccc/rei	Patch
@ckb-ccc/shell	Patch
@ckb-ccc/spore	Patch
@ckb-ccc/ssri	Patch
@ckb-ccc/type-id	Patch
@ckb-ccc/udt	Patch
@ckb-ccc/uni-sat	Patch
@ckb-ccc/utxo-global	Patch
@ckb-ccc/xverse	Patch
@ckb-ccc/ccc	Patch
ckb-ccc	Patch
@ckb-ccc/connector	Patch
@ckb-ccc/connector-react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for liveccc ready!

Name	Link
🔨 Latest commit	a137473
🔍 Latest deploy log	https://app.netlify.com/projects/liveccc/deploys/696209e45414d7000879ce92
😎 Deploy Preview	https://deploy-preview-349--liveccc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 31 (🔴 down 10 from production) Accessibility: 88 (no change from production) Best Practices: 92 (🔴 down 8 from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[netlify]

✅ Deploy Preview for apiccc ready!

Name	Link
🔨 Latest commit	a137473
🔍 Latest deploy log	https://app.netlify.com/projects/apiccc/deploys/696209e4e0e8ca0008ea542d
😎 Deploy Preview	https://deploy-preview-349--apiccc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 82 (🔴 down 12 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 95 (🟢 up 1 from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[netlify]

✅ Deploy Preview for docsccc ready!

Name	Link
🔨 Latest commit	a137473
🔍 Latest deploy log	https://app.netlify.com/projects/docsccc/deploys/696209e4cc351e0008af4f68
😎 Deploy Preview	https://deploy-preview-349--docsccc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 66 (🔴 down 2 from production) Accessibility: 88 (no change from production) Best Practices: 92 (no change from production) SEO: 92 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[gemini-code-assist]

Summary of Changes

Hello @Hanssen0, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the core library by introducing robust support for CKB multisig transactions. It provides new abstract and concrete signer classes, refactors existing signing mechanisms for better modularity, and improves transaction witness argument handling. The changes aim to make multisig operations more accessible and reliable for developers, complete with illustrative examples.

Highlights

• Multisig Signers: Introduced new SignerMultisigCkbPrivateKey and SignerMultisigCkbReadonly classes to provide comprehensive support for CKB multisig transactions, including creation, preparation, and signing.
• Codec Decorator Relaxation: Relaxed the type restriction for the @ccc.codec decorator, allowing more flexible codec definitions and improving usability.
• Transaction Witness Handling: Added a new Transaction.getWitnessArgsAtUnsafe method that throws an error on decoding failure, complementing the existing getWitnessArgsAt which returns undefined.
• Signing Logic Refactoring: Refactored the SignerCkbPrivateKey to extract the secp256k1 signing logic into a reusable signMessageCkbSecp256k1 function.
• Multisig Examples: Added two new example files, transferFromMultisig.ts and transferToMultisig.ts, demonstrating how to interact with multisig addresses and transactions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces multisig signer capabilities, which is a significant feature. The changes include new SignerMultisigCkbPrivateKey and SignerMultisigCkbReadonly classes, along with a new SignerMultisig abstract class. The implementation looks mostly correct, but I've found a few issues:

• A critical bug in getSignaturesCount that would cause incorrect signature counting.
• A misleading example in transaction.ts for a new method.
• Some minor issues like a console.log and an incorrect error message.
• I've also pointed out a potential API inconsistency in one of the new example files.

Please address these points to improve the quality and correctness of the code. Overall, good work on adding this complex feature.

[netlify]

✅ Deploy Preview for appccc ready!

Name	Link
🔨 Latest commit	a137473
🔍 Latest deploy log	https://app.netlify.com/projects/appccc/deploys/696209e61019e10008c1b88c
😎 Deploy Preview	https://deploy-preview-349--appccc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 62 (🔴 down 25 from production) Accessibility: 89 (🟢 up 1 from production) Best Practices: 92 (🔴 down 8 from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[Hanssen0]

Related to #196

@ashuralyk, please review.

[Hanssen0]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a significant feature: support for multisig signers in @ckb-ccc/core. It also includes a major dependency upgrade for @noble packages and a migration of the build system to tsdown. The core logic for creating, signing, and aggregating multisig transactions is well-implemented, and the refactoring to accommodate the new dependency versions is clean. My review includes a few suggestions to improve type safety and error message clarity.

[Hanssen0]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces significant new functionality by adding multisig signer support for CKB, a major feature for the core package. It also includes a substantial dependency upgrade for all @noble packages to their latest major versions and a migration of the build system to tsdown. The implementation of the multisig feature is well-structured, separating read-only and private key signing logic, and is accompanied by new tests and examples. The breaking changes from the dependency upgrades seem to be handled correctly throughout the codebase. My review includes a few suggestions to enhance maintainability and correct a minor documentation error.

[Hanssen0]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces significant new functionality for multisig signers in the core package, which is a valuable addition. The implementation is well-structured, with clear abstractions for multisig signers and thorough handling of CKB-specific multisig logic, including witness encoding, signature aggregation, and transaction preparation.

The PR also includes a major version bump for @noble dependencies, and the necessary code adaptations for the new APIs are correctly implemented across the affected modules. The migration of the build process to tsdown is a good modernization step.

I have one suggestion for a minor refactoring to reduce code duplication. Overall, this is a high-quality contribution with good test coverage and examples for the new features.