Skip to content

Conversation

@kriegfrj
Copy link

@kriegfrj kriegfrj commented Nov 3, 2020

Hi Chris,

Here is a workaround for your problem. Fixes the NCDFE under Java 1.8 by forcing Bnd to generate an Import-Package declaration for org.osgi.framework in your tests bundle.

I think this is an osgi-test bug. I'll raise an issue on osgi-test and we'll follow up.

Blessings!

@chrisr3
Copy link
Owner

chrisr3 commented Nov 4, 2020

Thanks for looking into this, @kriegfrj. I'll admit to a small amount of relief that there actually was a problem to find, and that I hadn't just done something silly without realising it 😀 .

@kriegfrj
Copy link
Author

kriegfrj commented Nov 5, 2020

Thanks for looking into this, @kriegfrj. I'll admit to a small amount of relief that there actually was a problem to find, and that I hadn't just done something silly without realising it 😀 .

I know the feeling! Thanks for being an early-adopter - although it's frustrating for you, it makes it much more likely that we will find bugs in more esoteric cases.

Btw, @bjhargrave (being the super-efficient developer that he is) has already merged the patch for the bug in osgi-test: eclipse-osgi-technology/osgi-test#230. The workaround in this PR will get you through until the next osgi-test release (or until you're brave enough to try out HEAD of osgi-test 😉)

@chrisr3
Copy link
Owner

chrisr3 commented Nov 5, 2020

Btw, @bjhargrave (being the super-efficient developer that he is) has already merged the patch for the bug in osgi-test: osgi/osgi-test#230. The workaround in this PR will get you through until the next osgi-test release (or until you're brave enough to try out HEAD of osgi-test wink)

Yes, I saw 😮 ! Thanks to everyone 😀. Happily I am not in a rush to upgrade from 0.9.0, and even 0.10.0 seems to work (for now) on Java 11. My repo is very much an "experiment with OSGi", and exists precisely to discover things like this before other team members trip over them. With any luck, everyone wins 🎊.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants