Fix issue #61 add invoke-chocolatey which throws error on choco error #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esiebes
changed the title
| } | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
This probably can't influence the exit code of the run can it?
Author
There was a problem hiding this comment.
exit code is now handled in pull request 103
| ( | ||
| # Param1 help description | ||
| [Parameter(Position=0)] | ||
| $pParams |
Member
There was a problem hiding this comment.
Can we just call this arguments?
| function Invoke-Chocolatey | ||
| { | ||
| [CmdletBinding()] | ||
| [Alias("IChoco")] |
Author
There was a problem hiding this comment.
alias removed in pullrequest 103
| { | ||
| [CmdletBinding()] | ||
| [Alias("IChoco")] | ||
| [OutputType([int])] |
Member
There was a problem hiding this comment.
How will this work with choco list -lo -r that pipes the text output?
Author
|
i |
Author
|
please see pullrequest 103. |
Member
|
Closed in favor of #103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#61
resolution for issue 61. In our company me an my colleagues also noticed that cchoco always returned succes even when chocolatey gave an error. This fix wil throw an error if chocolatey gives an error.