Skip to content

Conversation

@munechika-koyo
Copy link
Member

  • Implemented load_cameras and load_bolometers functions with improved geometry handling.

  • Updated project to require Python 3.10 or higher.

  • Added module docstrings and type hints for clarity.

  • Introduced CameraType and GeometryType enums for better type management.

  • Refactored functions to enhance type hinting and documentation.

  • Fixed import statements and configuration for linting tools.

…ing in `load_cameras` and `from_value` methods
To handle geometry attributes effectively with type annotations.
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 0.39841% with 250 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.57%. Comparing base (930549f) to head (27ec817).
⚠️ Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
src/cherab/imas/observer/bolometer.py 0.00% 119 Missing ⚠️
src/cherab/imas/ids/bolometer/_camera.py 0.00% 105 Missing ⚠️
src/cherab/imas/ids/bolometer/utility.py 0.00% 21 Missing ⚠️
src/cherab/imas/ids/bolometer/__init__.py 0.00% 3 Missing ⚠️
src/cherab/imas/observer/__init__.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #24      +/-   ##
===========================================
- Coverage    48.60%   48.57%   -0.03%     
===========================================
  Files           43       43              
  Lines         2076     2077       +1     
  Branches       341      341              
===========================================
  Hits          1009     1009              
- Misses         947      948       +1     
  Partials       120      120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@munechika-koyo munechika-koyo merged commit 5f300c5 into develop Dec 9, 2025
@munechika-koyo munechika-koyo deleted the feature/bolometer branch December 9, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants