add private locations changelog #120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logs and references of changes)
thebiglabasky
requested changes
Dec 4, 2025
Contributor
thebiglabasky
left a comment
thebiglabasky
left a comment
There was a problem hiding this comment.
Made some minor suggestions. I wonder about the consistency between past tense or present tense (Added feature X / Add feature X) since we use both interchangeably. I'd stick to one or the other.
MariadeAnton
commented
Dec 4, 2025
MariadeAnton
commented
Dec 4, 2025
Co-authored-by: Hervé Labas <431257+thebiglabasky@users.noreply.github.com>
Co-authored-by: Hervé Labas <431257+thebiglabasky@users.noreply.github.com>
Contributor
Author
|
@thebiglabasky ready for re-review! |
thebiglabasky
approved these changes
Dec 5, 2025
Contributor
thebiglabasky
left a comment
thebiglabasky
left a comment
There was a problem hiding this comment.
There are still some past and some present tense, but I think it's not important enough to warrant changes. That reads fine! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes a changelog space for all change logs.