Added httpclient param to ApiConfig, set minimum .NET Framework version to 4.6.2. #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed ApiUtil to use that client. The timeout property gets and sets the client's timeout directly.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Is there any possibility that this solution could be merged? We need this for testing and monitoring. |
Author
I don;t think Chargebee devs do anything with PRs, it's been 2 years. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to pass in an existing httpclient to ApiConfig. Refactored ApiUtil to use that client. The timeout property gets and sets the client's timeout directly.
This allows for easier unit / integration testing as well as reuse of HttpClients already available in consuming code.
I set minimum .NET Framework version to 4.6.2 because .NET 4.5 has been out of support for a long time now.