Issues with receiving consecutive LoRa messages #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reset the sequence number for each line request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the issue that i was unable to receive multiple consecutive LoRa packets.
These could be tracked to the handling of the sequence number of the edge events in the
monitorfunction.Here the events
line_seqnois used for de-duplication, however this is only unique per specific line.My approach to resolving this issue was to simply reset the stored
self.seqnoat the beginning of the monitor function. This impacts the event de-duplication, however I do not believe this poses an issue.Alternatively, one could use the events global_seqno in order to have the guarantee that no event is handled twice.