Skip to content

Conversation

@rapgro
Copy link

@rapgro rapgro commented Jul 24, 2019

@michaelblyons
Copy link

michaelblyons commented Jul 24, 2019

I am not the repo owner (or even a contributor) so take this with a shaker of salt:

If syncing to the latest lwip is important, would you consider converting it to a submodule? Then, reviewing this change doesn't drag one through 600 changed files. The lwip section of this project pre-dates Git submodules, and I think it's a prime example of their foremost purpose.

@rapgro
Copy link
Author

rapgro commented Jul 24, 2019

Agreed, with a submodule it seems the proper way to go. But when you read the documentation provided from the lwip project, they suggest to bundle the sources in the client application(s). The license is BSD, so forks shouldn't be of any issue at all. No idea what internals like API changed with the new sources.
All in all, if someone can refactor the sources to have a proper API with a submodule, I'd be the last guy against such a progress.

@rapgro
Copy link
Author

rapgro commented Jul 24, 2019

The main reason why I decided to build with newer lwip sources was taken because of several gcc warnings I wanted to fix to be able to provide good packaging (Fedora).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants