debian: stop using dh_python2 ${python:Depends} #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dh_python2 parses the `requires.txt` files in Calamari and
Calamari's bundled libraries, it translates the dependencies listed
there into "python-" packages and adds them into ${python:Depends}.
In the past this has led to the calamari-server .deb depending on system
packages that do not exist, which leads to installation failures.
Since ${python:Depends} doesn't work well with Calamari's method of
bundling libraries in a virtualenv, just remove it and hard-code the
list of python Depends in /debian/control.
(I've just copied & pasted the existing list that dh_python2 was already
picking up, so maybe this Depends list could be trimmed further, with
experimentation.)
Contributor
Author
|
This will fix the |
Contributor
|
@ktdreyer Great work! Thank you |
Contributor
Author
|
1.3 cherry-pick is #529 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dh_python2 parses the
requires.txtfiles in Calamari and Calamari's bundled libraries, it translates the dependencies listed there into "python-" packages and adds them into${python:Depends}.In the past this has led to the calamari-server .deb depending on system packages that do not exist, which leads to installation failures.
Since
${python:Depends}doesn't work well with Calamari's method of bundling libraries in a virtualenv, just remove it and hard-code the list of python Depends in /debian/control.(I've just copied & pasted the existing list that dh_python2 was already picking up, so maybe this Depends list could be trimmed further, with experimentation.)