split config classes into separate files, add missing @Directive tags #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Yeah there's a lot going on in this PR, files moved around, spaces removed, etc... I'd rather have smaller ones. Also, I'd rather keep the config in the same file as the directive (e.g. |
Contributor
Author
|
Yeah those splits are necessary in order to reflect on the config classes (kotlin reflection does not support facade classes yet). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You may wish to do this yourself as this commit may skew statistics on the repo. These changes improve the index that can be auto-generated with https://github.com/pabl0rg/kobalt-dsl-documenter