Rework software architecture section by Thomas Kiley #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The top sections are filled out to give an idea of content
This section outlines the key ideas for the rest of the episode.
This relates more to the descriptions of good code, so we might as well have this discussion before introducing new concepts
The section ends with revisiting this list, so explicitly request people keep hold of it. Add some glue text to make the list flow better
Is more common and essentially the same as MVVM.
Makes the callout formatting work better
Introduce a problem that classes will solve. Use consistent circle example all through. Make header more accurate. Remove benifits of using classes - we are introducing a big benifit, don't want to muddy the waters with other benifits.
Since Python doesn't really have interfaces, and most of the benifits of having interfaces are not supported by Python, this needlessly complicates the lesson. Instead talking about common interfaces for different classes.
Since all we are omiting is the docstring, we can leave that as implict and make it clear there is no code before the load call
Now MVC comes after classes make sure the examples in classes do not contain the changes done as part of MVC, and that the classes changes are in the MVC examples
Instead allows the student to focus on observing and then testing current behaviour, rather than getting bogged down in implemenation details
This should make the exercise clearer.
This matches up with the variable names in the original code, making the refactoring more obvious
This isn't really a solution, and I think just muddies the meaning of the section
Co-authored-by: Matthew <matthew.bluteau@gmail.com>
Adding in the four lines for the "full data analysis" shifts these errors down by four lines.
anenadic
changed the title
Collaborator
Author
|
This PR is superseded by PR #296. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replicates a previous PR #234 by @thomaskileyukaea as a local branch on this repo.
Once merged, it fixes #227 (but merge only after #286 is merged, which should take priority).
I am reviewing this PR in a separate PR #297