-
-
Notifications
You must be signed in to change notification settings - Fork 76
Expanded diagram to include git pull using Mermaid JS tool. #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I like this new Mermaid drawing tool - many thanks for bringing it to our attention @thomaskileyukaea. |
|
I have now removed the link to the Mermaid-generated SVG and kept the local SVG only, after having a conversation with @steve-crouch on 2023-11-07 about adding another dependency to the lesson material, which we are not sure of the lifetime or support of (in the future). |
steve-crouch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments, but is much clearer with regards to the local or remote context for git operations.
| your local copy (using `git fetch` or `git pull`) to keep the two in sync | ||
| in order to collaborate (with a bonus that your work also gets backed up to another machine). | ||
|
|
||
| {: .image-with-shadow width="600px"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this now need to be removed since we have the more sustainable replacement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed via 12bc35f.
|
Thank you very much for the review @steve-crouch. Merging next. |
Fixes #173 but keeping this a draft PR for the time being as it needs the new layout that supports mermaid drawings (in PR #226), unless we just decide to keep the SVG version of the new diagram.
Also improves the wording a bit around Git infrastructure.