Skip to content

Conversation

@anenadic
Copy link
Collaborator

@anenadic anenadic commented Nov 2, 2023

Fixes #173 but keeping this a draft PR for the time being as it needs the new layout that supports mermaid drawings (in PR #226), unless we just decide to keep the SVG version of the new diagram.

Also improves the wording a bit around Git infrastructure.

@anenadic anenadic marked this pull request as draft November 2, 2023 21:59
@anenadic
Copy link
Collaborator Author

anenadic commented Nov 2, 2023

I like this new Mermaid drawing tool - many thanks for bringing it to our attention @thomaskileyukaea.

@anenadic
Copy link
Collaborator Author

anenadic commented Nov 7, 2023

I have now removed the link to the Mermaid-generated SVG and kept the local SVG only, after having a conversation with @steve-crouch on 2023-11-07 about adding another dependency to the lesson material, which we are not sure of the lifetime or support of (in the future).

@anenadic anenadic requested a review from steve-crouch November 7, 2023 11:54
@anenadic anenadic marked this pull request as ready for review November 9, 2023 10:58
Copy link
Collaborator

@steve-crouch steve-crouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, but is much clearer with regards to the local or remote context for git operations.

your local copy (using `git fetch` or `git pull`) to keep the two in sync
in order to collaborate (with a bonus that your work also gets backed up to another machine).

![Development lifecycle with Git](../fig/git-lifecycle.png){: .image-with-shadow width="600px"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this now need to be removed since we have the more sustainable replacement?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed via 12bc35f.

@anenadic
Copy link
Collaborator Author

anenadic commented Nov 9, 2023

Thank you very much for the review @steve-crouch. Merging next.

@anenadic anenadic merged commit 2f1a874 into gh-pages Nov 9, 2023
@anenadic anenadic deleted the issues-173 branch November 9, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redo git refresh diagram

3 participants