Improve initialization performance for pyramids with many levels. #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katamartin
reviewed
Oct 27, 2025
katamartin
reviewed
Oct 30, 2025
Member
katamartin
left a comment
katamartin
left a comment
There was a problem hiding this comment.
A couple of nits, but this is looking really great! And as discussed, would probably benefit from some testing.
| maxZoom, | ||
| tileSize, | ||
| crs, | ||
| } = this.store.describe() |
katamartin
reviewed
Oct 31, 2025
Member
katamartin
left a comment
katamartin
left a comment
There was a problem hiding this comment.
Another pair of nits, but otherwise lgtm!
Co-authored-by: Kata Martin <katasm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the UI blocking
openGroupcall on initialization which would block the UI for >1 second on a 12 level pyramid and replaces it with a system for lazy loading as needed by using the consolidated metadata.Tested this with a simple 12 (0-11) level pyramid as well as the more coordinate intensive OAE pyramid.