Add tests for ext-input-triggers protocol #375
Draft
+822
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: AlanGriffiths <9048879+AlanGriffiths@users.noreply.github.com>
- Fix grammatical error: "based tapping one a" → "based on tapping a" - Fix enum reference: enum="modifier" → enum="modifiers" - Fix spelling: "mult-touch" → "multi-touch" (2 occurrences) - Fix missing quote after "update" - Fix grammatical error: "progress an the" → "progress the" Co-authored-by: AlanGriffiths <9048879+AlanGriffiths@users.noreply.github.com>
Use Times(AtMost(1)) instead of Times(AnyNumber()) to better reflect the protocol requirement that exactly one of done() or failed() must be sent in response to trigger registration. Co-authored-by: AlanGriffiths <9048879+AlanGriffiths@users.noreply.github.com>
Co-authored-by: AlanGriffiths <9048879+AlanGriffiths@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add tests for ext-input-triggers
Add tests for ext-input-triggers protocol
Nov 5, 2025
Contributor
|
@copilot you seem to have added a lot of unrelated files. Please don't do that |
Prevent build artifacts from being committed. Co-authored-by: AlanGriffiths <9048879+AlanGriffiths@users.noreply.github.com>
The _codeql_build_dir directory should not have been committed. It's now properly listed in .gitignore. Co-authored-by: AlanGriffiths <9048879+AlanGriffiths@users.noreply.github.com>
This is another build artifact that should not be committed. Co-authored-by: AlanGriffiths <9048879+AlanGriffiths@users.noreply.github.com>
Contributor
Author
I've removed all the unrelated build artifacts. The |
TICS Quality Gate✔️ PassedNo changed files applicable for TICS analysis quality gating. TICS / TICS / Run TICS analysis |
Contributor
|
@copilot fixes to upstream protocols should be proposed upstream, not applied here |
These fixes should be proposed upstream to the Mir project, not applied here. Reverting to the original protocol files from the upstream Mir PR #4328. Co-authored-by: AlanGriffiths <9048879+AlanGriffiths@users.noreply.github.com>
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.