-
Notifications
You must be signed in to change notification settings - Fork 58
Update Azure golden images doc to support 22.04 FIPS #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update Azure golden images doc to support 22.04 FIPS #462
Conversation
Update to use Sphinx's code-block directive to get better syntax highlighting.
Updates the guide for creating golden images to work for Ubuntu 22.04 and newer. There are differences in the underlying offers using from 22.04 onward which require some changes to the instructions. These differences mean the image publisher/offer/sku is not included in the attested metadata and therefore attaching to Pro requires some additional steps.
| subscriptionID=$(az account show --query id --output tsv) | ||
| Create a variable for your subscription ID: | ||
| Create variables for gallery name, image definition name and Ubuntu Pro plan to be used. If you have an Ubuntu Pro private offer with Canonical that includes 24x7 technical support with SLAs, you'll have a custom offer and SKU, which can be used here. If not, as seen in the example below, you can use any Pro image that is publicly available at the Azure Marketplace. The image will be displayed in the Azure Portal as ``sigName/imageDefName``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A link to the find-Ubuntu-images-on-Azure how-to would be helpful here.
| --publisher $ProPlanPublisher \ | ||
| --offer $ProPlanOffer \ | ||
| --sku $ProPlanSku \ | ||
| --os-type Linux \ | ||
| --plan-name $ProPlanSku \ | ||
| --plan-product $ProPlanOffer \ | ||
| --plan-publisher $ProPlanPublisher \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do publisher, offer, and sku differ from plan-publisher, plan-product, and plan-name?
| jq 'del(.properties.source.planInfo)' $imageTemplateFile > temp.json && mv temp.json $imageTemplateFile | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superfluous empty line
| --ssh-key-values $SSHPublicKeyPath \ | ||
| --public-ip-sku Standard | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superfluous empty line
| --generate-ssh-keys \ | ||
| --public-ip-sku Standard | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superfluous empty line
| } | ||
| You can use the ``publicIpAddress`` (``51.143.126.x`` in this case) to ssh into the machine. To check that the VM is attached to an Ubuntu Pro subscription and is running a FIPS kernel, run: | ||
| You can use the ``publicIpAddress`` (``51.143.126.x`` in this case) to ssh into the machine. Using the following instructions to attach the VM to an Ubuntu Pro subscription: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, I think we should explicitly differentiate between < 22.04 and >= 22.04. The end user should understand what to expect regardless of whether they are using an image from one of the example lines in this document.
| sudo pro status --wait | ||
| .. code-block:: sh | ||
| az vm update \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This manual post-launch intervention would be less than ideal in an auto-scaling setting. As discussed over Mattermost, we may want to instead removing the instruction to detach. Let's discuss offline tomorrow.
I tested and confirmed the instructions work for Pro FIPS 22.04 and Pro FIPS 20.04.