client: keep original PATH when executing local scripts #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the original PATH when executing local scripts, such that repack/adhoc snippets which reference tools installed in custom locations are able to access them. Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
zyga
approved these changes
Jan 10, 2025
Contributor
zyga
left a comment
zyga
left a comment
There was a problem hiding this comment.
I'm not sure why /snap/bin is there but it's already better than the current broken behaviour.
Contributor
Author
I'm guessing it's being added as a workaround for snapd (and thus /snap/bin) becoming available while the current shell is already executing a script that invokes spread. Most likely only relevant for some CI workflows, but I'd prefer to not break things for anyone and keep backward compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the original PATH when executing local scripts, such that repack/adhoc snippets which reference tools installed in custom locations are able to access them.