replace strlen() with strlen_c()

[thomaskroi1996]

Closes #4551

Hello, as discussed with @Saviq and @tarek-y-ismail, this is my attempt at replacing the strlen() calls throughout the codebase with a constexpr function!

I added the constexpr_strlen.h file in include/common/mir and made the function a inline, since it just returns the size of a string_view. This should work with string literals, and I didn't have any failed tests after replacing all the calls!

The only file where I didn't replace them was xcursor.c, since there i couldn't include <string_view>, as xcursor is a c file.

Let me know any suggestions, thanks!

Checklist

• Tests added and pass
• Adequate documentation added
• (optional) Added Screenshots or videos

[Saviq]

@thomaskroi1996 you commited a lot of changes that shouldn't be here (mostly formatting, and the removal of options.md.include.

Please only check in changes relevant to the problem you're working on.

I recommend git -vp, never do git add -a :)

[thomaskroi1996]

ah, ups, that was my VSCode autosave, i am sorry for that, will fix it!

[Saviq]

Let's rename the file to something like constexpr_utils.h, so more can be introduced.

[AlanGriffiths]

Thanks for this. There are a few practice we follow on the project that will help with using this code, hope they are not too burdensome

[AlanGriffiths]

You've been a bit overzealous in using strlen_c - it only useful for string literals.

Also a couple of clarifications.

And the title of the PR also needs updating.

[AlanGriffiths]

We should prefer the standard library function (which developers should be familiar with) unless there is a reason to use the constexpr version

[AlanGriffiths]

There’s a couple of files with no meaningful changes. Otherwise looking good

[AlanGriffiths]

Looks good. Thank you

Stale