Add ability to configure a worker_queue and remove Fabric::WebhookWorker
#36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jclusso
force-pushed
the
add-configurable-worker-queue
branch
from
1d29fa2 to
6fd5cf2
Compare
Member
Author
|
@danarnold I fixed this PR to support those options. |
…orker - This works by overriding the `perform_async` method. I was surprised this works, but it does. - Additionally, Fabric::WebhookWorker has been removed. Using it is not ideal as it silences errors that Stripe would normally retry.
jclusso
force-pushed
the
add-configurable-worker-queue
branch
from
6fd5cf2 to
7206134
Compare
jclusso
changed the title
worker_queueworker_queue and remove Fabric::WebhookWorker
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to configure the worker queue via a new Fabric.config attribute and removes the legacy Fabric::WebhookWorker to ensure errors aren’t silenced during Stripe webhook processing.
- Overrides perform_async, perform_in, and perform_at in Worker to dynamically set the queue from configuration.
- Removes the Fabric::WebhookWorker and updates the documentation and configuration accordingly.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/fabric/app/workers/worker.rb | Overrides asynchronous methods to use the configurable queue, removing the hard-coded 'fabric' queue. |
| lib/fabric/app/workers/webhook_worker.rb | Completely removed as part of deprecating error-silencing webhook processing. |
| lib/fabric.rb | Updates require statements and adds a new worker_queue configuration with default value 'critical'. |
| README.md | Removes outdated asynchronous usage instructions referencing the removed WebhookWorker. |
Comments suppressed due to low confidence (2)
lib/fabric/app/workers/worker.rb:38
- Consider adding a brief inline comment explaining why perform_async, perform_in, and perform_at are overridden to set the queue dynamically using Fabric.config.worker_queue. This will improve maintainability and ease future modifications.
def perform_async(...)
lib/fabric.rb:145
- It would be beneficial to include a comment or update related documentation to explain the purpose and expected values for the new worker_queue configuration attribute.
attr_accessor :worker_queue
danarnold
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perform_asyncmethod. I was surprised this works, but it does.