Skip to content

Conversation

@dboyliao
Copy link
Collaborator

@dboyliao dboyliao commented Dec 31, 2025

  • xalign interactive order flags
    • new flag for user config: InteractiveOrderEnabled
    • automatically disable interactive order if the slack interaction feature is not enabled by the user

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a feature flag for interactive orders in the xalign strategy with automatic disabling when Slack interaction is not configured. The change introduces a getter method SlackInteractionEnabled() on the bbgo.Environment to check if Slack interaction is enabled, and adds the InteractiveOrderEnabled flag to the xalign strategy configuration to control whether orders require interactive Slack confirmation.

Key Changes

  • New SlackInteractionEnabled() getter method in bbgo.Environment to expose the interactive Slack state
  • Added InteractiveOrderEnabled configuration flag to the xalign strategy
  • Modified order placement logic to bypass interactive confirmation when the feature is disabled

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
pkg/bbgo/environment.go Adds interactiveSlackEnabled field and SlackInteractionEnabled() getter to expose Slack interaction state
pkg/strategy/xalign/strategy.go Adds InteractiveOrderEnabled configuration field and updates order placement logic to check if interactive orders are enabled
pkg/strategy/xalign/slack.go Adds isInteractiveOrderEnabled() helper method and updates setupSlackInteractionCallback() to accept an enabled flag
pkg/strategy/xalign/slack_test.go Updates test call to setupSlackInteractionCallback() with new signature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dboyliao dboyliao force-pushed the dboy/xalign/interative-order-flag branch 6 times, most recently from 7397cc1 to 8433119 Compare January 2, 2026 02:48
@dboyliao dboyliao force-pushed the dboy/xalign/interative-order-flag branch from 8433119 to 4dcbe67 Compare January 2, 2026 02:53
@dboyliao dboyliao enabled auto-merge January 2, 2026 05:46
@dboyliao dboyliao merged commit 1ad7250 into main Jan 2, 2026
3 checks passed
@dboyliao dboyliao deleted the dboy/xalign/interative-order-flag branch January 2, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants