REFACTOR: improve batch query #1371
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FEATURE: [max] update deposit states and add more fields to deposit
FEATURE: [bybit] support query account/balance api
FIX: [deposit2transfer] add lastAssetDepositTimes for immediate success deposits
FEATURE: [bybit] add k line api
FEATURE: [bybit] add trade info event
FIX: [deposit2transfer] apply rate limiter on checkDeposits
Improve: profitStatsTracker, Add a parameter for window to sum up trades
REFACTOR: rename file and variable
Update README.md
Update CONTRIBUTING.md
Modified README.md file's language.
FEATURE: [batch] add a jumpIfEmpty to batch trade option
…on-2 FEATURE: [batch] add jumpIfEmpty opts to closed order batch query
…n-function FEATURE: prepare query trades funtion for new recover
…jumpIfEmpty param
bailantaotao
requested review from
c9s,
chechiachang,
gx578007,
kbearXD,
narumiruna and
ycdesu
|
Welcome back! @bailantaotao, This pull request may get 257 BBG. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1371 +/- ##
=======================================
Coverage 20.99% 20.99%
=======================================
Files 568 567 -1
Lines 40623 40627 +4
=======================================
+ Hits 8529 8531 +2
- Misses 31463 31465 +2
Partials 631 631
Continue to review full report in Codecov by Sentry.
|
c9s
approved these changes
Oct 26, 2023
bailantaotao
force-pushed
the
edwin/improve-batch-query
branch
from
bb29973 to
1448c05
Compare
|
Re-estimated karma: this pull request may get 271 BBG |
Collaborator
Author
|
added more comments in bybti func |
c9s
approved these changes
Nov 17, 2023
Owner
|
do you want to merge this? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.