Skip to content

Conversation

@Mododo
Copy link
Member

@Mododo Mododo commented Jan 15, 2026

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

None

BLOCKCHAIN CONFIGURATION MODEL CHANGES

None


COMPATIBILITY

Full

SPECIAL DEPLOYMENT ACTIONS

  • rustup update stable for 1.91 msrv

TESTS

Unit Tests

Added behavioral unit tests as a specification

Network Tests

No coverage

Manual Tests

transfers-30k


Notes/Additional Comments:

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=998

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=998
  • Run specific test: gh workflow run network-tests.yml -f pr_number=998 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@Mododo Mododo requested review from 0xdeafbeef and Rexagon January 15, 2026 11:13
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 84.12162% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.72%. Comparing base (7d0cd44) to head (a9fe0cc).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
consensus/src/dag/commit/mod.rs 56.00% 10 Missing and 1 partial ⚠️
consensus/src/models/cert.rs 95.40% 4 Missing and 4 partials ⚠️
consensus/src/models/point_status.rs 0.00% 7 Missing ⚠️
consensus/src/dag/verifier.rs 79.31% 5 Missing and 1 partial ⚠️
consensus/src/dag/dag_point_future.rs 0.00% 4 Missing ⚠️
...c/mempool/impls/single_node_impl/anchor_handler.rs 0.00% 3 Missing ⚠️
consensus/src/dag/commit/back.rs 75.00% 2 Missing and 1 partial ⚠️
...lator/src/mempool/impls/std_impl/anchor_handler.rs 0.00% 2 Missing ⚠️
consensus/src/test_utils/anchor_consumer.rs 0.00% 2 Missing ⚠️
consensus/src/engine/committer_task.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
- Coverage   54.76%   54.72%   -0.04%     
==========================================
  Files         362      363       +1     
  Lines       63573    63788     +215     
  Branches    63573    63788     +215     
==========================================
+ Hits        34814    34908      +94     
- Misses      26833    26947     +114     
- Partials     1926     1933       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mododo Mododo enabled auto-merge January 15, 2026 11:30
@Mododo Mododo self-assigned this Jan 15, 2026
@Mododo Mododo added this to the 020 Consensus milestone Jan 15, 2026
@Mododo Mododo force-pushed the feature/consensus/cert-depth branch 3 times, most recently from a52ad0a to 0ad6f4b Compare January 15, 2026 23:49
@Mododo Mododo force-pushed the feature/consensus/cert-depth branch from 0ad6f4b to 7a0e364 Compare January 16, 2026 00:50
evidences certify the point and `commit_history_depth` rounds of its dependencies
@Mododo Mododo force-pushed the feature/consensus/cert-depth branch from 7a0e364 to a9fe0cc Compare January 16, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants