Skip to content

Conversation

@Rexagon
Copy link
Member

@Rexagon Rexagon commented Jan 7, 2026

There is a couple of improvements which we could make for stored cells:

  • Don't store repr hash since it is already a cell hash;
  • Properly route cell hashes for lower levels of pruned cells.

For now this is a breaking change, but the migration is possible.

  • Compare disk usage (done: 23 GiB old vs 16 GiB new on testnet after the cold boot only);
  • Add migration (done: reassembles cell values while also removing items with zero rc; runs for ~1 minute).

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=994

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=994
  • Run specific test: gh workflow run network-tests.yml -f pr_number=994 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 51.94175% with 99 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.60%. Comparing base (7d0cd44) to head (ef22e4c).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
core/src/storage/db/migrations.rs 0.00% 80 Missing ⚠️
core/src/storage/shard_state/cell_storage.rs 88.59% 1 Missing and 12 partials ⚠️
core/src/storage/db/mod.rs 40.00% 2 Missing and 1 partial ⚠️
core/src/block_strider/starter/cold_boot.rs 0.00% 1 Missing ⚠️
...src/storage/persistent_state/shard_state/writer.rs 66.66% 0 Missing and 1 partial ⚠️
core/src/storage/shard_state/store_state_raw.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
- Coverage   54.76%   54.60%   -0.17%     
==========================================
  Files         362      364       +2     
  Lines       63573    63837     +264     
  Branches    63573    63837     +264     
==========================================
+ Hits        34814    34856      +42     
- Misses      26833    27030     +197     
- Partials     1926     1951      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rexagon Rexagon force-pushed the fix/pruned-cell-hash branch from 3d1a88c to 404e465 Compare January 13, 2026 11:56
@Rexagon Rexagon force-pushed the fix/pruned-cell-hash branch 2 times, most recently from 0f875e2 to b12b691 Compare January 13, 2026 17:25
@Rexagon Rexagon marked this pull request as ready for review January 13, 2026 17:35
@Rexagon Rexagon force-pushed the fix/pruned-cell-hash branch from b12b691 to 5cac111 Compare January 13, 2026 17:40
@Rexagon Rexagon force-pushed the fix/pruned-cell-hash branch from 5809da0 to ef22e4c Compare January 16, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants