Skip to content

Conversation

@Mododo
Copy link
Member

@Mododo Mododo commented Jan 6, 2026

This is an arch review for the moderator core.
There will be another PR to bind existing code and make use of new component.

Pull Request Checklist

NODE CONFIGURATION MODEL CHANGES

Yes: added ban config and journal storage duration (with defaults)

BLOCKCHAIN CONFIGURATION MODEL CHANGES

None


COMPATIBILITY

Full. Added new column families in mempool db

SPECIAL DEPLOYMENT ACTIONS

Not Required


PERFORMANCE IMPACT

No impact expected


TESTS

Unit Tests

Added some tests for basic units

Network Tests

No coverage

Manual Tests

transfers-30k, simulator


Notes/Additional Comments:

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=992

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=992
  • Run specific test: gh workflow run network-tests.yml -f pr_number=992 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@Mododo Mododo requested review from 0xdeafbeef and Rexagon January 6, 2026 13:40
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 24.76489% with 960 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.90%. Comparing base (bb2d3cc) to head (8b23e2e).

Files with missing lines Patch % Lines
consensus/src/moderator/impl_.rs 3.42% 141 Missing ⚠️
consensus/src/moderator/ban/core.rs 0.00% 109 Missing ⚠️
consensus/src/moderator/journal/event.rs 0.00% 109 Missing ⚠️
consensus/src/moderator/ban/cache.rs 45.31% 96 Missing and 9 partials ⚠️
consensus/src/storage/journal_store.rs 0.00% 73 Missing ⚠️
consensus/src/moderator/journal/item.rs 0.00% 61 Missing ⚠️
consensus/src/intercom/peer_schedule/impl_.rs 0.00% 59 Missing ⚠️
consensus/src/moderator/ban/state.rs 0.00% 59 Missing ⚠️
consensus/src/storage/db.rs 0.00% 54 Missing ⚠️
consensus/src/moderator/journal/batch.rs 0.00% 49 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #992      +/-   ##
==========================================
- Coverage   46.27%   45.90%   -0.38%     
==========================================
  Files         360      374      +14     
  Lines       62584    63818    +1234     
  Branches    62584    63818    +1234     
==========================================
+ Hits        28961    29293     +332     
- Misses      32108    32978     +870     
- Partials     1515     1547      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mododo Mododo added this to the 020 Consensus milestone Jan 6, 2026
@Mododo Mododo self-assigned this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants