Skip to content

Conversation

@0xdeafbeef
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 19, 2025

🧪 Network Tests

To run network tests for this PR, use:

gh workflow run network-tests.yml -f pr_number=984

Available test options:

  • Run all tests: gh workflow run network-tests.yml -f pr_number=984
  • Run specific test: gh workflow run network-tests.yml -f pr_number=984 -f test_selection=ping-pong

Test types: destroyable, ping-pong, one-to-many-internal-messages, fq-deploy, nft-index, persistent-sync

Results will be posted as workflow runs in the Actions tab.

@github-actions
Copy link

❌ CLI reference check failed in CI.

Please run just update_cli_reference, add the updated docs/cli-reference.md, and push the changes.

@0xdeafbeef 0xdeafbeef force-pushed the rpc-subs branch 2 times, most recently from d664dd7 to fcdbc9b Compare December 19, 2025 16:51
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 65.63367% with 743 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.52%. Comparing base (bb2d3cc) to head (ed86cf1).

Files with missing lines Patch % Lines
rpc-subscriptions/src/perf_tests/mod.rs 27.45% 214 Missing ⚠️
rpc-subscriptions/src/perf_tests/common.rs 60.04% 162 Missing and 9 partials ⚠️
rpc/src/endpoint/jrpc/stream.rs 69.42% 78 Missing and 7 partials ⚠️
rpc-subscriptions/src/index/subscriptions.rs 75.72% 76 Missing and 8 partials ⚠️
rpc/src/state/mod.rs 14.63% 70 Missing ⚠️
rpc/src/state/subscriptions.rs 66.34% 31 Missing and 4 partials ⚠️
rpc/src/endpoint/jrpc/mod.rs 0.00% 30 Missing ⚠️
rpc-subscriptions/src/manager.rs 87.38% 21 Missing and 6 partials ⚠️
rpc-subscriptions/src/clients/mod.rs 89.04% 5 Missing and 3 partials ⚠️
rpc-subscriptions/src/index/forward/tests.rs 86.36% 1 Missing and 5 partials ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #984      +/-   ##
==========================================
- Coverage   46.27%   45.52%   -0.76%     
==========================================
  Files         360      398      +38     
  Lines       62584    66702    +4118     
  Branches    62584    66702    +4118     
==========================================
+ Hits        28961    30365    +1404     
- Misses      32108    34783    +2675     
- Partials     1515     1554      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

❌ CLI reference check failed in CI.

Please run just update_cli_reference, add the updated docs/cli-reference.md, and push the changes.

@0xdeafbeef 0xdeafbeef force-pushed the rpc-subs branch 3 times, most recently from 38be993 to a2ce344 Compare December 29, 2025 11:29
@0xdeafbeef
Copy link
Member Author

no stream

[2025-12-29T15:13:22Z INFO  nekroddos::latency] Latency test results:
[2025-12-29T15:13:22Z INFO  nekroddos::latency] Successful transactions: 20
[2025-12-29T15:13:22Z INFO  nekroddos::latency] Failed transactions: 0
[2025-12-29T15:13:22Z INFO  nekroddos::latency] Average latency: 1.445413428s
[2025-12-29T15:13:22Z INFO  nekroddos::latency] P50 latency: 1.246627722s
[2025-12-29T15:13:22Z INFO  nekroddos::latency] P95 latency: 2.391300962s
[2025-12-29T15:13:22Z INFO  nekroddos::latency] P99 latency: 2.391300962s

with

[2025-12-29T15:14:29Z INFO  nekroddos::latency] Latency test results:
[2025-12-29T15:14:29Z INFO  nekroddos::latency] Successful transactions: 20
[2025-12-29T15:14:29Z INFO  nekroddos::latency] Failed transactions: 0
[2025-12-29T15:14:29Z INFO  nekroddos::latency] Average latency: 1.515285739s
[2025-12-29T15:14:29Z INFO  nekroddos::latency] P50 latency: 1.222546639s
[2025-12-29T15:14:29Z INFO  nekroddos::latency] P95 latency: 2.419251574s
[2025-12-29T15:14:29Z INFO  nekroddos::latency] P99 latency: 2.419251574s

or other run

[2025-12-29T15:15:23Z INFO  nekroddos::latency] Latency test results:
[2025-12-29T15:15:23Z INFO  nekroddos::latency] Successful transactions: 20
[2025-12-29T15:15:23Z INFO  nekroddos::latency] Failed transactions: 0
[2025-12-29T15:15:23Z INFO  nekroddos::latency] Average latency: 1.327957188s
[2025-12-29T15:15:23Z INFO  nekroddos::latency] P50 latency: 1.200880153s
[2025-12-29T15:15:23Z INFO  nekroddos::latency] P95 latency: 2.475582525s
[2025-12-29T15:15:23Z INFO  nekroddos::latency] P99 latency: 2.475582525s

Latency is pretty jittery

@0xdeafbeef 0xdeafbeef force-pushed the rpc-subs branch 2 times, most recently from 03d2d5f to 6aebede Compare January 6, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants