modify: total tries for binary start. fix: unit tests

Author: rchougule

setup-local/config/constants.js

@@ -49,7 +49,7 @@ module.exports = {
     },
   },
 
-  BINARY_MAX_TRIES: 2,
+  BINARY_MAX_TRIES: 3,
 
   RESTRICTED_LOCAL_ARGS: ['k', 'key', 'local-identifier', 'daemon', 'only-automate', 'verbose', 'log-file', 'ci-plugin'],
 

setup-local/dist/index.js

@@ -13489,7 +13489,7 @@ module.exports = {
     },
   },
 
-  BINARY_MAX_TRIES: 2,
+  BINARY_MAX_TRIES: 3,
 
   RESTRICTED_LOCAL_ARGS: ['k', 'key', 'local-identifier', 'daemon', 'only-automate', 'verbose', 'log-file', 'ci-plugin'],
 

setup-local/test/binaryControl.test.js

@@ -385,9 +385,9 @@ describe('Binary Control Operations', () => {
         binaryControl._removeAnyStaleBinary.restore();
       });
 
-      it('Delete any stale local binary (non windows)', () => {
+      it('Delete any stale local binary (non windows)', async () => {
         binaryControl.platform = PLATFORMS.DARWIN;
-        binaryControl._removeAnyStaleBinary();
+        await binaryControl._removeAnyStaleBinary();
         const binaryZipPath = path.resolve(binaryControl.binaryFolder, LOCAL_BINARY_ZIP);
         const staleBinaryPath = path.resolve(
           binaryControl.binaryFolder,
@@ -397,9 +397,9 @@ describe('Binary Control Operations', () => {
         sinon.assert.calledWith(io.rmRF, staleBinaryPath);
       });
 
-      it('Delete any stale local binary (windows)', () => {
+      it('Delete any stale local binary (windows)', async () => {
         binaryControl.platform = PLATFORMS.WIN32;
-        binaryControl._removeAnyStaleBinary();
+        await binaryControl._removeAnyStaleBinary();
         const binaryZipPath = path.resolve(binaryControl.binaryFolder, LOCAL_BINARY_ZIP);
         const staleBinaryPath = path.resolve(
           binaryControl.binaryFolder,