chore: binary zip name in constant

Author: rchougule

setup-local/config/constants.js

@@ -55,5 +55,6 @@ module.exports = {
 
   LOCAL_BINARY_FOLDER: 'LocalBinaryFolder',
   LOCAL_BINARY_NAME: 'BrowserStackLocal',
+  LOCAL_BINARY_ZIP: 'binaryZip',
   LOCAL_LOG_FILE_PREFIX: 'BrowserStackLocal',
 };

setup-local/dist/index.js

@@ -1080,6 +1080,7 @@ const {
   LOCAL_BINARY_FOLDER,
   PLATFORMS,
   LOCAL_BINARY_NAME,
+  LOCAL_BINARY_ZIP,
   LOCAL_LOG_FILE_PREFIX,
   LOCAL_BINARY_TRIGGER,
   BINARY_MAX_TRIES,
@@ -1214,7 +1215,7 @@ class BinaryControl {
   }
 
   async _removeAnyStaleBinary() {
-    const binaryZip = path.resolve(this.binaryFolder, 'binaryZip');
+    const binaryZip = path.resolve(this.binaryFolder, LOCAL_BINARY_ZIP);
     const previousLocalBinary = path.resolve(
       this.binaryFolder,
       `${LOCAL_BINARY_NAME}${this.platform === PLATFORMS.WIN32 ? '.exe' : ''}`,
@@ -1241,7 +1242,10 @@ class BinaryControl {
       this._removeAnyStaleBinary();
 
       core.info('Downloading BrowserStackLocal binary...');
-      const downloadPath = await tc.downloadTool(this.binaryLink, path.resolve(this.binaryFolder, 'binaryZip'));
+      const downloadPath = await tc.downloadTool(
+        this.binaryLink,
+        path.resolve(this.binaryFolder, LOCAL_BINARY_ZIP),
+      );
       const extractedPath = await tc.extractZip(downloadPath, this.binaryFolder);
       core.info(`BrowserStackLocal binary downloaded & extracted successfuly at: ${extractedPath}`);
       const cachedPath = await tc.cacheDir(extractedPath, LOCAL_BINARY_NAME, '1.0.0');
@@ -13491,6 +13495,7 @@ module.exports = {
 
   LOCAL_BINARY_FOLDER: 'LocalBinaryFolder',
   LOCAL_BINARY_NAME: 'BrowserStackLocal',
+  LOCAL_BINARY_ZIP: 'binaryZip',
   LOCAL_LOG_FILE_PREFIX: 'BrowserStackLocal',
 };
 

setup-local/src/binaryControl.js

@@ -15,6 +15,7 @@ const {
   LOCAL_BINARY_FOLDER,
   PLATFORMS,
   LOCAL_BINARY_NAME,
+  LOCAL_BINARY_ZIP,
   LOCAL_LOG_FILE_PREFIX,
   LOCAL_BINARY_TRIGGER,
   BINARY_MAX_TRIES,
@@ -149,7 +150,7 @@ class BinaryControl {
   }
 
   async _removeAnyStaleBinary() {
-    const binaryZip = path.resolve(this.binaryFolder, 'binaryZip');
+    const binaryZip = path.resolve(this.binaryFolder, LOCAL_BINARY_ZIP);
     const previousLocalBinary = path.resolve(
       this.binaryFolder,
       `${LOCAL_BINARY_NAME}${this.platform === PLATFORMS.WIN32 ? '.exe' : ''}`,
@@ -176,7 +177,10 @@ class BinaryControl {
       this._removeAnyStaleBinary();
 
       core.info('Downloading BrowserStackLocal binary...');
-      const downloadPath = await tc.downloadTool(this.binaryLink, path.resolve(this.binaryFolder, 'binaryZip'));
+      const downloadPath = await tc.downloadTool(
+        this.binaryLink,
+        path.resolve(this.binaryFolder, LOCAL_BINARY_ZIP),
+      );
       const extractedPath = await tc.extractZip(downloadPath, this.binaryFolder);
       core.info(`BrowserStackLocal binary downloaded & extracted successfuly at: ${extractedPath}`);
       const cachedPath = await tc.cacheDir(extractedPath, LOCAL_BINARY_NAME, '1.0.0');

setup-local/test/binaryControl.test.js

@@ -18,6 +18,7 @@ const {
   LOCAL_BINARY_FOLDER,
   PLATFORMS,
   LOCAL_BINARY_NAME,
+  LOCAL_BINARY_ZIP,
   LOCAL_LOG_FILE_PREFIX,
   LOCAL_BINARY_TRIGGER,
   ALLOWED_INPUT_VALUES: {
@@ -387,7 +388,7 @@ describe('Binary Control Operations', () => {
       it('Delete any stale local binary (non windows)', () => {
         binaryControl.platform = PLATFORMS.DARWIN;
         binaryControl._removeAnyStaleBinary();
-        const binaryZipPath = path.resolve(binaryControl.binaryFolder, 'binaryZip');
+        const binaryZipPath = path.resolve(binaryControl.binaryFolder, LOCAL_BINARY_ZIP);
         const staleBinaryPath = path.resolve(
           binaryControl.binaryFolder,
           `${LOCAL_BINARY_NAME}`,
@@ -399,7 +400,7 @@ describe('Binary Control Operations', () => {
       it('Delete any stale local binary (windows)', () => {
         binaryControl.platform = PLATFORMS.WIN32;
         binaryControl._removeAnyStaleBinary();
-        const binaryZipPath = path.resolve(binaryControl.binaryFolder, 'binaryZip');
+        const binaryZipPath = path.resolve(binaryControl.binaryFolder, LOCAL_BINARY_ZIP);
         const staleBinaryPath = path.resolve(
           binaryControl.binaryFolder,
           `${LOCAL_BINARY_NAME}.exe`,