Breez signer #487
Open
Breez signer #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeierez
force-pushed
the
breez-signer
branch
from
4620bbf to
44d1dae
Compare
roeierez
force-pushed
the
breez-signer
branch
from
7dff500 to
37035fa
Compare
Collaborator
danielgranhao
left a comment
danielgranhao
left a comment
There was a problem hiding this comment.
Looking good! Just a few comments
Comment on lines
+42
to
+44
| let builder = | ||
| lnurl_models::nostr::create_zap_receipt(zap_request, invoice, preimage.clone()) | ||
| .map_err(NostrError::ZapReceiptCreationError)?; |
Collaborator
There was a problem hiding this comment.
Nit, but IMO helps with readability
Suggested change
| let builder = | |
| lnurl_models::nostr::create_zap_receipt(zap_request, invoice, preimage.clone()) | |
| .map_err(NostrError::ZapReceiptCreationError)?; | |
| let builder = | |
| lnurl_models::nostr::create_zap_receipt_event_builder(zap_request, invoice, preimage.clone()) | |
| .map_err(NostrError::ZapReceiptCreationError)?; |
| .map_err(|e| SdkError::Generic(e.to_string()))?, | ||
| ); | ||
|
|
||
| // Create the signer from seed |
Collaborator
There was a problem hiding this comment.
Nit: comment should be moved up
Comment on lines
-338
to
-346
| // Use legacy master key when using default key set and default derivation path for backwards compatibility | ||
| let master_key = | ||
| if self.key_set_type == KeySetType::Default && self.account_number.is_none() { | ||
| let bitcoin_network: bitcoin::Network = self.config.network.into(); | ||
| Xpriv::new_master(bitcoin_network, &seed_bytes) | ||
| .map_err(|e| SdkError::Generic(e.to_string()))? | ||
| } else { | ||
| key_set.identity_master_key | ||
| }; |
Collaborator
There was a problem hiding this comment.
Does something replace this to maintain backwards compatibility?
| path: &DerivationPath, | ||
| ) -> Result<secp256k1::schnorr::Signature, SdkError>; | ||
|
|
||
| fn derive_public_key(&self, path: &DerivationPath) -> Result<secp256k1::PublicKey, SdkError>; |
Collaborator
There was a problem hiding this comment.
Should this be async?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the signing architecture by introducing a unified
BreezSignertrait and specialized adapter implementations:BreezSignerImpl: Core signer with BIP32 key derivationSparkSigner: Adapter for spark-wallet operationsNostrSigner: Adapter for Nostr event signingRTSyncSigner: Adapter for real-time sync signing/encryption