Use on conflict instead of replacing payment table rows #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangeross
force-pushed
the
savage-payment-update-persistence
branch
2 times, most recently
from
1f70fc6 to
8dd65ba
Compare
JssDWt
approved these changes
Dec 1, 2025
Comment on lines
555
to
557
| lnurl_pay_info=COALESCE(excluded.lnurl_pay_info, payment_metadata.lnurl_pay_info), | ||
| lnurl_withdraw_info=COALESCE(excluded.lnurl_withdraw_info, payment_metadata.lnurl_withdraw_info), | ||
| lnurl_description=COALESCE(excluded.lnurl_description, payment_metadata.lnurl_description)", |
Member
There was a problem hiding this comment.
Are we setting here or partially updating? Asking because the name of the function implies setting but seems like existing values that are not updated are not being overridden anymore.
Collaborator
Author
There was a problem hiding this comment.
True, the name is inconsistent now as we only take the updated value if its not null. I'm fine reverting this for set_payment_metadata. I think the most important are the handling of payment and payment details related tables. Wdyt?
danielgranhao
approved these changes
Dec 2, 2025
dangeross
force-pushed
the
savage-payment-update-persistence
branch
from
0823ef4 to
08dd127
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the persistence of payments to use "ON CONFLICT" instead of "OR REPLACE" to avoid payment and foreign table rows being dropped when a payment is updated. For example spark invoice details or HTLC statuses are persisted between payment updates. This allows syncing payment data from multiple sources without losing data (e.g. syncing data from spark and flashnet) or storing a payment with non spark data before the initial transfer is synced