Skip to content

Fix leaking login thread in test_login_in_thread_retries_on_failure #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
delner merged 1 commit into from
Dec 29, 2025
Merged

Fix leaking login thread in test_login_in_thread_retries_on_failure #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions test/braintrust/state_login_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,9 @@ def test_login_with_invalid_api_key
end

def test_login_in_thread_retries_on_failure
state = Braintrust::State.new(
api_key: @api_key,
app_url: "https://www.braintrust.dev"
)

# Disable VCR to allow WebMock stubs to work properly
# IMPORTANT: Disable VCR and set up stubs BEFORE creating State, because
# State.new immediately spawns a background login thread when no org_id
# is provided. If stubs aren't ready, the thread hits WebMock errors.
VCR.turn_off!
begin
# Stub HTTP to fail twice, then succeed
Expand All @@ -71,8 +68,12 @@ def test_login_in_thread_retries_on_failure
)

begin
# Start background login
state.login_in_thread
# Now create State - this spawns the login thread with stubs already in place
state = Braintrust::State.new(
api_key: @api_key,
app_url: "https://www.braintrust.dev",
enable_tracing: false
)

# Wait for it to complete (should retry and eventually succeed)
state.wait_for_login(5)
Expand Down