-
Notifications
You must be signed in to change notification settings - Fork 60
Pnpm 10 #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ignoredBuiltDependencies: | ||
| - "@parcel/watcher" | ||
| - bufferutil | ||
| - es5-ext | ||
| - esbuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid skipping esbuild install step
Listing esbuild under ignoredBuiltDependencies tells pnpm 10 to skip lifecycle scripts for that package. esbuild relies on its postinstall hook to download and wire up the platform-specific binary; without it, a fresh pnpm install leaves node_modules/.bin/esbuild missing and build scripts such as apis/node's build:local/build:lambda (and the proxy’s own build commands) fail immediately with “esbuild was not installed correctly”. If those scripts are still needed, esbuild shouldn’t be ignored here.
Useful? React with 👍 / 👎.
ankrgyl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as lingua, do we need to make mise a requirement?
ankrgyl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as lingua, do we need to make mise a requirement?
No description provided.