Skip to content

Conversation

@ibolmo
Copy link
Collaborator

@ibolmo ibolmo commented Dec 29, 2025

No description provided.

@ibolmo ibolmo self-assigned this Dec 29, 2025
@vercel
Copy link

vercel bot commented Dec 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
ai-proxy Ready Ready Preview, Comment Dec 29, 2025 10:38pm

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +5 to +9
ignoredBuiltDependencies:
- "@parcel/watcher"
- bufferutil
- es5-ext
- esbuild

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid skipping esbuild install step

Listing esbuild under ignoredBuiltDependencies tells pnpm 10 to skip lifecycle scripts for that package. esbuild relies on its postinstall hook to download and wire up the platform-specific binary; without it, a fresh pnpm install leaves node_modules/.bin/esbuild missing and build scripts such as apis/node's build:local/build:lambda (and the proxy’s own build commands) fail immediately with “esbuild was not installed correctly”. If those scripts are still needed, esbuild shouldn’t be ignored here.

Useful? React with 👍 / 👎.

Copy link
Contributor

@ankrgyl ankrgyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as lingua, do we need to make mise a requirement?

Copy link
Contributor

@ankrgyl ankrgyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as lingua, do we need to make mise a requirement?

@ibolmo ibolmo merged commit 22ef521 into main Dec 29, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants