Set TopP/top_p to undefined for all model providers
#361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ibolmo
approved these changes
Dec 18, 2025
Collaborator
ibolmo
left a comment
ibolmo
left a comment
There was a problem hiding this comment.
discussed privately. approving to unblock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gemini defaults to 0.95 -> https://docs.cloud.google.com/vertex-ai/generative-ai/docs/models/gemini/3-pro
i think it's completely optional for anthropic -> https://platform.claude.com/docs/en/api/messages/create
openai defaults to 1 -> https://platform.openai.com/docs/api-reference/chat/create
im thinking we just set it to undefined so we don't have to keep up with changes to defaults at the model API layer and the UI isn't as confusing when fetching defaults.
ran the new defaults of
undefinedlocally for proxy: