refactor: optimize performance with memoization in EditorInput and Me… #359
+114
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntionPlugin components
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| type TMenuComponent, | ||
| type TMenuItemComponent, | ||
| } from './mention-plugin/mention-plugin'; | ||
| import MentionNode from './mention-plugin/mention-node'; |
There was a problem hiding this comment.
What: Ensure that the memoization of initialConfig does not lead to stale values due to dependencies not being included.
Why: Memoization can cause the configuration to retain old values if dependencies are not carefully managed, which could lead to unexpected behavior in the component.
How: Ensure that all relevant state and props that could change and are used in initialConfig are included in the dependency array of useMemo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntionPlugin components
Description
Screenshots | Video with voice-over
Link to Figma (If applicable)
How has this been tested?
Checklist: