-
Notifications
You must be signed in to change notification settings - Fork 3
Add new page for science elective and add it to toc #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
content/undergraduate/sci.md
Outdated
| :header-rows: 1 | ||
|
|
||
| "Code", "Course Title", "Notes" | ||
| "BIOXXX", "All 3- or 4-credits non-laboratory BIOXXX courses", "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like half dashes and may create ambiguity with numbers.
"3 or 4 credits ..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
content/undergraduate/sci.md
Outdated
| @@ -0,0 +1,92 @@ | |||
| {#cc_top} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure but this may clash with some tags in other CC page.
Let's fix it to {#sci_top}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing this out. I have replaced it with {#sci_top}.
content/undergraduate/sci.md
Outdated
| :widths: 10 60 30 | ||
| :header-rows: 1 | ||
|
|
||
| "Code", "Course Title", "Credits" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have credits info for CC courses. It is irrelevant in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced the credits column with a notes column to align with other tables and support future notes.
content/index.md
Outdated
| - [Undergraduate Program Documentation]() | ||
| - [Rules and Regulations](undergraduate/regulations) | ||
| - [List of Complementary Courses](undergraduate/cc) | ||
| - [List of Science Elective Courses](undergraduate/sci) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We must think how the URL appears in the address bar.
Option 1:
undergraduate/cc-electivesundergraduate/science-electives
Option 2:
undergraduate/electives/ccundergraduate/electives/science
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would favor Option 2 in the long run if the documentation grows to include many pages across multiple topics. However, since it is unclear whether the structure will become that complex, I opted for Option 1 for now to keep things simple, avoid additional directory nesting, and prevent unnecessary expansion of the documentation hierarchy.
5de165c to
d65f32b
Compare
This PR introduces a new page for science electives.