Skip to content

Replace deprecated unload handler with pagehide/pageshow in media-control-api.js #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ignatremizov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace deprecated unload handler with pagehide/pageshow in media-control-api.js #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions extension/media-control-api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,17 @@ document.addEventListener("MediaControlStateChanged", function (event) {
}
});

// Unregister tab before move to another URI
window.onunload = function() {
// Unregister tab before navigating away or entering bfcache
window.addEventListener("pagehide", function () {
chrome.runtime.sendMessage({command: "unregisterTab"});
};
});

// If restored from bfcache, re-register based on current controllable state
window.addEventListener("pageshow", function (event) {
if (event.persisted) {
registerOrUnregisterPage(isPageMediaControllable());
}
});

// Initial tab registration by meta tag
registerOrUnregisterPage(isPageMediaControllable());
Expand All @@ -55,4 +62,4 @@ function isPageMediaControllable() {

function registerOrUnregisterPage(register) {
chrome.runtime.sendMessage({command: register ? "registerTab" : "unregisterTab"});
}
}