Skip to content

Conversation

@zees-dev
Copy link
Collaborator

Description

This pull request simplifies the BlessCrawl module by removing unused FFI functions (map and crawl) and their corresponding implementations. It also refactors the map and crawl methods in the BlessCrawl struct to provide placeholder implementations instead of relying on the removed FFI functions.

Removal of FFI functions:

  • Removed the map and crawl functions from the FFI interface in the extern "C" block, as they are no longer used. (src/bless_crawl/mod.rs, src/bless_crawl/mod.rsL43-L68)
  • Removed the mock implementations of the map and crawl functions from the mock_ffi module. (src/bless_crawl/mod.rs, src/bless_crawl/mod.rsL92-L119)

Refactoring of BlessCrawl methods:

  • Refactored the map method to remove the FFI-based implementation and replace it with a placeholder that returns an empty MapData response. (src/bless_crawl/mod.rs, src/bless_crawl/mod.rsL528-R488)
  • Refactored the crawl method to remove the FFI-based implementation and replace it with a placeholder that returns an empty CrawlData response. (src/bless_crawl/mod.rs, src/bless_crawl/mod.rsL586-L662)

@zees-dev zees-dev requested review from Copilot and uditdc June 27, 2025 02:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the BlessCrawl module by removing unused FFI functions and their corresponding mock implementations and replaces the FFI-based logic in the map and crawl methods with simple placeholder implementations.

  • Removed FFI functions and their mocks from the extern "C" block and the mock_ffi module.
  • Refactored the map and crawl methods to return default/empty responses with placeholder TODO comments.

@zees-dev zees-dev requested a review from Joinhack June 27, 2025 02:23
@zees-dev zees-dev merged commit da5012b into main Jun 27, 2025
1 check passed
@zees-dev zees-dev deleted the feat/bless-crawl-refactor branch June 27, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants