Refactor/dev 234 create treasury endpoint #1508
Open
+1,054
−560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add TreasuryService with provider interface - Implement DefiLlama provider for treasury data - Implement Dune provider as fallback option - Add treasury-provider-factory for dynamic provider initialization - Support for liquid treasury historical data 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Add DEFILLAMA_API_URL optional environment variable - Add TREASURY_PROVIDER_PROTOCOL_ID for provider configuration - Update .env.example with treasury provider examples 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Rename fetchTotalAssets to fetchLiquidTreasury - Move DuneResponse type to treasury providers - Update import to use treasury provider types - Remove obsolete types.ts file 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Update assets controller to use TreasuryService - Replace DuneService instantiation with createTreasuryProvider factory - Change endpoint from /total-assets to /liquid-treasury - Add order parameter support for historical data sorting - Remove totalAssets import from controllers 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Update @types/pg to version 8.15.4 - Update pnpm lockfile 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pikonha
reviewed
Dec 22, 2025
pikonha
reviewed
Dec 22, 2025
pikonha
reviewed
Dec 22, 2025
pikonha
reviewed
Dec 22, 2025
apps/indexer/src/api/services/treasury/providers/treasury-provider.interface.ts
Outdated
Show resolved
Hide resolved
| }); | ||
|
|
||
| // Create timeline from first data point to today | ||
| const timeline = createDailyTimelineFromData(liquidMap); |
Member
There was a problem hiding this comment.
can this be moved to inside the forward fill func?
Member
Author
There was a problem hiding this comment.
It can… but I think it’s better to keep it separated.
- Make each thing responsible for a single responsibility.
- The treasury functions can keep using the timeline generated by calling createDailyTimelineFromData. If you take a look at that function in this file, the output of createDailyTimelineFromData is not used only for the forward fill.
apps/indexer/src/api/services/treasury/providers/coingecko-price-provider.ts
Outdated
Show resolved
Hide resolved
Comment on lines
60
to
89
| export const useTreasury = ( | ||
| daoId: DaoIdEnum, | ||
| type: TreasuryType = "total", | ||
| days: TimeInterval = TimeInterval.ONE_YEAR, | ||
| options?: { | ||
| order?: "asc" | "desc"; | ||
| config?: Partial<SWRConfiguration<TreasuryResponse, Error>>; | ||
| }, | ||
| ) => { | ||
| const { order = "asc", config } = options || {}; | ||
| const key = daoId ? ["treasury", daoId, type, days, order] : null; | ||
|
|
||
| const { data, error, isValidating, mutate } = useSWR<TreasuryResponse>( | ||
| key, | ||
| () => fetchTreasury({ daoId, type, days, order }), | ||
| { | ||
| revalidateOnFocus: false, | ||
| shouldRetryOnError: false, | ||
| ...config, | ||
| }, | ||
| ); | ||
|
|
||
| return { | ||
| data: data?.items ?? [], | ||
| totalCount: data?.totalCount ?? 0, | ||
| loading: isValidating, | ||
| error, | ||
| refetch: mutate, | ||
| }; | ||
| }; |
Member
There was a problem hiding this comment.
Suggested change
| export const useTreasury = ( | |
| daoId: DaoIdEnum, | |
| type: TreasuryType = "total", | |
| days: TimeInterval = TimeInterval.ONE_YEAR, | |
| options?: { | |
| order?: "asc" | "desc"; | |
| config?: Partial<SWRConfiguration<TreasuryResponse, Error>>; | |
| }, | |
| ) => { | |
| const { order = "asc", config } = options || {}; | |
| const key = daoId ? ["treasury", daoId, type, days, order] : null; | |
| const { data, error, isValidating, mutate } = useSWR<TreasuryResponse>( | |
| key, | |
| () => fetchTreasury({ daoId, type, days, order }), | |
| { | |
| revalidateOnFocus: false, | |
| shouldRetryOnError: false, | |
| ...config, | |
| }, | |
| ); | |
| return { | |
| data: data?.items ?? [], | |
| totalCount: data?.totalCount ?? 0, | |
| loading: isValidating, | |
| error, | |
| refetch: mutate, | |
| }; | |
| }; | |
| export const useTreasury = ( | |
| daoId: DaoIdEnum, | |
| type: TreasuryType = "total", | |
| days: TimeInterval = TimeInterval.ONE_YEAR, | |
| order: "asc" | "desc" = "asc", | |
| ) => { | |
| const { data, error, isValidating } = useSWR<TreasuryResponse>( | |
| ["treasury", daoId, type, days, order], | |
| () => fetchTreasury({ daoId, type, days, order }), | |
| { | |
| revalidateOnFocus: false, | |
| shouldRetryOnError: false, | |
| }, | |
| ); | |
| return { | |
| data: data?.items ?? [], | |
| totalCount: data?.totalCount ?? 0, | |
| loading: isValidating, | |
| error, | |
| }; | |
| }; | |
apps/dashboard/features/attack-profitability/components/AttackCostBarChart.tsx
Outdated
Show resolved
Hide resolved
pikonha
requested review from
PedroBinotto,
alextnetto,
brunod-e and
edulennert
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.