Skip to content

Conversation

@noopur23
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings November 13, 2025 17:09
@noopur23 noopur23 merged commit 03a55aa into release Nov 13, 2025
4 checks passed
@noopur23 noopur23 deleted the docker-ci branch November 13, 2025 17:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the auto-release workflow to improve tag creation handling and adds GitHub Release creation functionality. The changes implement a two-phase approach for tag creation (validation first, then creation) and introduce automated release creation when tags are successfully created.

  • Refactored tag creation logic to use flags for deferred execution, with explicit error handling for existing tags
  • Added GitHub Release creation step that triggers when version or network tags are created
  • Changed behavior from skipping to failing when tags already exist
Comments suppressed due to low confidence (1)

.github/workflows/auto-release.yml:59

  • Missing step ID. The new 'Create GitHub Release' step at line 105 references steps.create_tags.outputs, but this step lacks id: create_tags. Add id: create_tags to this step definition.
    - name: Create and push git tags

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

draft: false
prerelease: false
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAML indentation error. The GITHUB_TOKEN line should be indented with 2 spaces relative to env: to properly align as a child property. Currently it's at the same indentation level as env:.

Suggested change
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Copilot uses AI. Check for mistakes.
Comment on lines +106 to +109
uses: actions/create-release@v1
with:
tag_name: ${{ steps.get_tags_labels.outputs.git_tag != '' && steps.get_tags_labels.outputs.git_tag != 'null' && steps.get_tags_labels.outputs.git_tag || steps.get_tags_labels.outputs.zeam_tag }}
release_name: Release ${{ steps.get_tags_labels.outputs.git_tag != '' && steps.get_tags_labels.outputs.git_tag != 'null' && steps.get_tags_labels.outputs.git_tag || steps.get_tags_labels.outputs.zeam_tag }}
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions/create-release@v1 action is deprecated and no longer maintained. Consider using softprops/action-gh-release or the GitHub CLI (gh release create) instead for creating releases.

Suggested change
uses: actions/create-release@v1
with:
tag_name: ${{ steps.get_tags_labels.outputs.git_tag != '' && steps.get_tags_labels.outputs.git_tag != 'null' && steps.get_tags_labels.outputs.git_tag || steps.get_tags_labels.outputs.zeam_tag }}
release_name: Release ${{ steps.get_tags_labels.outputs.git_tag != '' && steps.get_tags_labels.outputs.git_tag != 'null' && steps.get_tags_labels.outputs.git_tag || steps.get_tags_labels.outputs.zeam_tag }}
uses: softprops/action-gh-release@v1
with:
tag_name: ${{ steps.get_tags_labels.outputs.git_tag != '' && steps.get_tags_labels.outputs.git_tag != 'null' && steps.get_tags_labels.outputs.git_tag || steps.get_tags_labels.outputs.zeam_tag }}
name: Release ${{ steps.get_tags_labels.outputs.git_tag != '' && steps.get_tags_labels.outputs.git_tag != 'null' && steps.get_tags_labels.outputs.git_tag || steps.get_tags_labels.outputs.zeam_tag }}

Copilot uses AI. Check for mistakes.
Comment on lines +108 to +110
tag_name: ${{ steps.get_tags_labels.outputs.git_tag != '' && steps.get_tags_labels.outputs.git_tag != 'null' && steps.get_tags_labels.outputs.git_tag || steps.get_tags_labels.outputs.zeam_tag }}
release_name: Release ${{ steps.get_tags_labels.outputs.git_tag != '' && steps.get_tags_labels.outputs.git_tag != 'null' && steps.get_tags_labels.outputs.git_tag || steps.get_tags_labels.outputs.zeam_tag }}
body: Release ${{ steps.get_tags_labels.outputs.git_tag != '' && steps.get_tags_labels.outputs.git_tag != 'null' && steps.get_tags_labels.outputs.git_tag || steps.get_tags_labels.outputs.zeam_tag }}
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditional logic doesn't properly handle cases where both version and network tags are created. The workflow only creates one release but may create two tags. Consider using the output flags to determine which tag was created: prefer git_tag when create_version_tag is true, otherwise use zeam_tag.

Suggested change
tag_name: ${{ steps.get_tags_labels.outputs.git_tag != '' && steps.get_tags_labels.outputs.git_tag != 'null' && steps.get_tags_labels.outputs.git_tag || steps.get_tags_labels.outputs.zeam_tag }}
release_name: Release ${{ steps.get_tags_labels.outputs.git_tag != '' && steps.get_tags_labels.outputs.git_tag != 'null' && steps.get_tags_labels.outputs.git_tag || steps.get_tags_labels.outputs.zeam_tag }}
body: Release ${{ steps.get_tags_labels.outputs.git_tag != '' && steps.get_tags_labels.outputs.git_tag != 'null' && steps.get_tags_labels.outputs.git_tag || steps.get_tags_labels.outputs.zeam_tag }}
tag_name: ${{ steps.create_tags.outputs.create_version_tag == 'true' && steps.get_tags_labels.outputs.git_tag || steps.get_tags_labels.outputs.zeam_tag }}
release_name: Release ${{ steps.create_tags.outputs.create_version_tag == 'true' && steps.get_tags_labels.outputs.git_tag || steps.get_tags_labels.outputs.zeam_tag }}
body: Release ${{ steps.create_tags.outputs.create_version_tag == 'true' && steps.get_tags_labels.outputs.git_tag || steps.get_tags_labels.outputs.zeam_tag }}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants