Skip to content

Add playwright example #4205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jonasherr wants to merge 2,434 commits into from
Closed

Add playwright example #4205

jonasherr wants to merge 2,434 commits into from

Conversation

@jonasherr
Copy link

@jonasherr jonasherr commented Aug 27, 2023

Closes: https://discord.com/channels/802917734999523368/802995521496023041/1138493519930064938

What are the changes and their implications?

This PR adds an example for playwright to the examples directory.

Changeset

I was not able to run pnpm changeset in my root directory.
Maybe someone could add it:
Changeset message: Playwright example added

Bug Checklist

  • Changeset added (run pnpm changeset in the root directory)
  • Integration test added (see test docs if needed)

Feature Checklist

PR for documentation: blitz-js/blitzjs.com#832

g3offrey and others added 30 commits October 6, 2021 13:04
@g3offrey @beerose
add a spinner during the blitz new version check (blitz-js#2791)
87eefaf 
(patch)

* add a spinner during the blitz new version check

* improve the ux on blitz new upgrade

* Apply suggestions from code review

Co-authored-by: Aleksandra Sikora <alexsandra.sikora@gmail.com>
@blitzjs-bot
(meta) updated @g3offrey contributions
ea566b2
@beerose
v0.41.0
b6adb74
@beerose
bump recipe/example versions (ignore)
ac4f9f3
@blitzjs-bot
(meta) updated @Vandivier contributions
e458224
@blitzjs-bot
(meta) added @namirsab as contributor
9e9c63d
@blitzjs-bot
(meta) added @scttcper as contributor
c4f6f78
Add missing information to stitches recipe README (blitz-js#2812)
cf448a8 
(meta)
@beerose
Prevent duplicated ComponentPropsWithoutRef import when installing ch…
5b4413d 
…akra-ui (blitz-js#2817)

(patch)
@beerose
Fix blitz new next steps message (blitz-js#2818)
bdc560a 
(patch)
@blitzjs-bot
(meta) updated @beerose contributions
baeefff
@namirsab
Show an error if a reserved word is used for blitz generate's model…
3473cec 
… name (blitz-js#2813)

(patch)
@blitzjs-bot
(meta) updated @namirsab contributions
350a98d
@Abduttayyeb
Fix typo in rfc-docs/01-architecture.md file (blitz-js#2824)
853254d 
(ignore)
@blitzjs-bot
(meta) added @Abduttayyeb as contributor
9e405aa
@maybebored
add tsdoc comments for withRouter and useRouter functions (blitz-…
cfdfb69 
…js#2784)

(meta)
@blitzjs-bot
(meta) added @maybebored as contributor
f3f85b6
@martinsaxa
show an error if invalid model name is passed to blitz generate (bl…
48f762c 
…itz-js#2802)

(patch)
@JuanM04
PR template update (blitz-js#2833)
f280035 
(ignore)
@piotrski
Make blitz codegen generate prisma client if prisma is installed (b…
c2e69b5 
…litz-js#2830)

(minor)
@blitzjs-bot
(meta) added @MuckHub as contributor
fa7ac11
@beerose
v0.41.1
93c03ea
@beerose
bump recipe/example versions (ignore)
3db0f77
@beerose
Add Cypress example (blitz-js#2836)
3d17eae
@p-siriphanthong
Improve error message on a duplicate page name error (blitz-js#2823)
df2c1dd 
(patch)
@blitzjs-bot
(meta) added @p-siriphanthong as contributor
6a539a3
@beerose
add a minimal app template (blitz-js#2764)
71be602 
(minor)
@JuanM04
Add authenticated layout support with Layout.authenticate (blitz-js…
1457ec8 
…#2825)

Co-authored-by: Brandon Bayer <b@bayer.ws> (minor)
@blitzjs-bot
(meta) added @shawn-fetanat as contributor
8a5596f
@beerose
add missing React import to LabeledTextField in fauna example (blitz-…
c29735f 
…js#2854)

(ignore)
blitzjs-bot and others added 20 commits June 7, 2022 13:05
@blitzjs-bot
(meta) added @minho42 as contributor
262b647
@blitzjs-bot
(meta) added @webdeb as contributor
9b8c403
@blitzjs-bot
(meta) added @idavidB as contributor
352d2af
@blitzjs-bot
(meta) updated @andreasasprou contributions
0366729
@blitzjs-bot
(meta) added @jakedee as contributor
8102086
@blitzjs-bot
(meta) added @datner as contributor
1c2fdfe
@blitzjs-bot
(meta) added @remlse as contributor
a98f972
@blitzjs-bot
(meta) added @sergous as contributor
525e436
@blitzjs-bot
(meta) updated @datner contributions
e1fc695
@flybayer
Update CODEOWNERS
a9c6bcc
@blitzjs-bot
(meta) added @Trancever as contributor
f0bbdf5
@blitzjs-bot
(meta) updated @Zeko369 contributions
7fd287f
@blitzjs-bot
(meta) updated @the-bayer contributions
f97c123
@blitzjs-bot
(meta) added @SerekKiri as contributor
e15c62a
@blitzjs-bot
(meta) added @iojcde as contributor
f59dfda
@blitzjs-bot
(meta) updated @iojcde contributions
fa6e967
@jonasherr
integrated playwright
2d0a24a
@jonasherr
integrated playwright
a726ca3
@jonasherr
integrated playwright
c35196a
@jonasherr
integrated playwright
f198142
@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2023

⚠️ No Changeset found

Latest commit: f198142

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddhsuresh
Copy link
Member

siddhsuresh commented Aug 27, 2023 •
edited
Loading

@jonasherr thanks for the PR, please change the branch to main.

@jonasherr jonasherr changed the base branch from canary to main August 27, 2023 09:47
@jonasherr jonasherr requested a review from flybayer as a code owner August 27, 2023 09:47
@jonasherr
Copy link
Author

jonasherr commented Aug 27, 2023

@jonasherr thanks for the PR, please change the branch to main.

Just updated it to main.
Thank you 😊

@siddhsuresh
Copy link
Member

siddhsuresh commented Oct 1, 2023

@jonasherr please re-open the PR with only your changes with the base branch as main. (You are currently merging all the commits from the legacy code)

@siddhsuresh siddhsuresh closed this Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flybayer flybayer Awaiting requested review from flybayer flybayer is a code owner

Assignees

No one assigned

Labels

status/done

Projects

Toolkit
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.