Skip to content

Conversation

@reez
Copy link
Contributor

@reez reez commented Oct 8, 2025

Description

Dumping the active (sealed) slot without a CVC causes the firmware to omit pubkey.

Our iOS app calls dump during scans; the generated Rust bindings assumed pubkey was always present and did unwrap(), which panicked and crashed the iOS app.

This change replaces the unwrap() with an ok_or(DumpError::SlotSealed) so callers receive a proper DumpError instead of aborting the process.

Also introduced #![allow(deprecated)] inside the emulator test module to silence the bdk_wallet::SignOptions deprecation because it was failing on CI because of that

Notes to the reviewers

Crash on iOS app found by @RockRockX2 reez/SatsBuddy#37

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory
Copy link
Member

notmandatory commented Oct 9, 2025

ACK 1d3561d

Thanks for the fix! Should I cut a new release or can you keep testing from the master branch incase there's something else to fix?

@notmandatory notmandatory merged commit 1d3561d into bitcoindevkit:master Oct 9, 2025
10 checks passed
@reez
Copy link
Contributor Author

reez commented Oct 9, 2025

yeah I can keep testing from the master branch 👍

@reez reez deleted the yo branch October 9, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants