Skip to content

Conversation

@colts661
Copy link
Contributor

@colts661 colts661 commented Apr 24, 2024

Fixed #100

Added validation to Daklapack order addresses before submitting to Daklapack:

  • Empty rows are disregarded
  • Rows with incomplete information are hold from private API call
    • Only insertion, address2 can be empty
    • These rows are reflected in the output
  • A private API call will not be made if there is no complete address in the file

Added tests in tests/test_route.py:

  • Adjusted the original test_post_submit_daklapack_order_success since it covers the optional fields condition
  • Added test_post_submit_daklapack_order_hold that will not make a private API call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blank Spreadsheet Rows on Daklapack Bulk Order

1 participant