Fix issue #11 - Report user guide #79
Conversation
s074
left a comment
s074
left a comment
There was a problem hiding this comment.
This one is almost good to go, only suggested one change this time around, good job 👍
s074
left a comment
s074
left a comment
There was a problem hiding this comment.
I requested some cleanup changes since the GUIDE report doesn't need any chatlogs
| { | ||
| const parser = event.getParser(); | ||
|
|
||
| addMessengerEntry({ id: -1, webId: parser.senderId, entityId: -1, name: userName, timestamp: ChatHistoryCurrentDate(), type: ChatEntryType.TYPE_IM, roomId: !roomSession ? 0 : roomSession.roomId, message: parser.chatMessage }); |
There was a problem hiding this comment.
Since we aren't sending any chatlogs we probably don't need to store the helper chatlog
| SendMessageComposer(new CallForHelpFromPhotoMessageComposer(activeReport.extraData, activeReport.cfhTopic, activeReport.roomId, GetSessionDataManager().userId, activeReport.roomObjectId)); | ||
| break; | ||
| case ReportType.GUIDE: | ||
| activeReport.reportedChats.forEach(entry => chats.push(entry.webId, entry.message)); |
There was a problem hiding this comment.
don't need to append any chats to the active report since the report doesn't need any chatlogs
| case ReportType.EMERGENCY: | ||
| return chatHistory.filter(chat => (chat.type === ChatEntryType.TYPE_CHAT) && (chat.webId === activeReport.reportedUserId) && (chat.entityType === RoomObjectType.USER)); | ||
| case ReportType.IM: | ||
| case ReportType.GUIDE: |
There was a problem hiding this comment.
GUIDE report won't need to select any chatlogs so remove this line as well
|
Hi @dank074 ! I have cleaned what you asked for. But right in the file On the other hand, if we put it as it is, we send it an empty message if it works. You can check it on your own if you want! Thanks for the information 👍 |
2 participants
Enabled the Report button when a user asks a Habbo Guide / Alpha / Guardian for help.