Skip to content

Conversation

@sdnjr
Copy link

@sdnjr sdnjr commented Sep 20, 2024

This PR fixes black screen when editing rooms with heights greater than 26.

It's weird to have a floor_editor.nitro but use values ​​internally, that was a bit confusing

@sdnjr
Copy link
Author

sdnjr commented Dec 3, 2024

If you use a client before the v2 branch, use this file: floor_editor.zip

@s074
Copy link
Collaborator

s074 commented Dec 3, 2024

This PR fixes black screen when editing rooms with heights greater than 26.

Is the client supposed to support height > 26 or is that custom?

@billsonnn
Copy link
Owner

This PR fixes black screen when editing rooms with heights greater than 26.

Is the client supposed to support height > 26 or is that custom?

answer discord 🙄

@sdnjr
Copy link
Author

sdnjr commented Dec 3, 2024

This PR fixes black screen when editing rooms with heights greater than 26.

Is the client supposed to support height > 26 or is that custom?

I made a typing mistake, it should actually be heights up to 29 (like flash)

so, yes

@s074
Copy link
Collaborator

s074 commented Dec 10, 2024

This PR fixes black screen when editing rooms with heights greater than 26.

Is the client supposed to support height > 26 or is that custom?

I made a typing mistake, it should actually be heights up to 29 (like flash)

so, yes

In that case @billsonnn should merge it.

About why the base64 image is currently inside the source instead of an asset: when I recoded floorplan I think bill was doing something with asset loading and so I temporarily hardcoded it. If you want to load it as an asset then you can and you should address that in this same PR probably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants