feat/songinfo: Show correct Songinfo in Inventory #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks, works perfectly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current dev branch, song names are only visible when placed in the room. In the inventory, the item name is
SONG_NAME.Current official implementation:
Look & feels with my changes:
This why I am committing this PR. As you can see, the name is written bold in the inventory, like in the official client. Also, the description is visible. The name is used for the creator's name, the description is used for the song title. Because the songinfo can lazy load, a callback is also implemented and cleared when not used.
I hope this implementation is in the spirit of @billsonnn and @dank074 if not i am open for changes. 🙌🏼