Specifically fail when encoding JSON for undefined #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
The
jsonhelper should always produce syntactically correct JS. Since the use case for the helper is usuallyvar something = {{{json something}}};. If a variable is trying to encode is undefined it would produce a difficult incorrect syntax likevar something = ;.So, instead, just fail! This is probably a big deal and will impact things.
Related to bigcommerce/cornerstone#1404 bigcommerce/cornerstone#1425
How was it tested?
Added test case.
Thank you for consideration.
cc @bigcommerce/storefront-team @jbruni