Code review #1
Open
Code review #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation only contains a single exception class but the code refers to multiple classes ImsServiceException and ImsException. There does not seem to be a need for multiple exception classes so only use one: ImsException. Update code referring to ImsServiceException accordingly.
Code located in the module should not be executed if the module is not enabled.
It is unneeded and variable assignment in arguments is confusing.
The inner exception (usually SoapFault) may include valuable information which is not a part of the exception message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👍 Solid work
Reviewing code in a new repository can be tricky as there is usually no PR containing all the changes. I have tried to provide comments that I suggest should lead directly to changes to the codebase as commits in this PR with the commit comment explaining the reasoning behind. I suggest you go through each of these and cherry pick the ones that you agree with. Note that the changes are entirely untested.
Some additional comments for your consideration: