Skip to content

[PWGCF] Please consider the following formatting changes to #9369 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bghanley1995 merged 1 commit into from
Jan 21, 2025
Merged

[PWGCF] Please consider the following formatting changes to #9369 #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions PWGCF/TwoParticleCorrelations/TableProducer/identifiedBfFilter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// In applying this license CERN does not waive the privileges and immunities
// granted to it by virtue of its status as an Intergovernmental Organization
// or submit itself to any jurisdiction.

Check warning on line 11 in PWGCF/TwoParticleCorrelations/TableProducer/identifiedBfFilter.h

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \file is missing, incorrect or misplaced.

Check warning on line 11 in PWGCF/TwoParticleCorrelations/TableProducer/identifiedBfFilter.h

View workflow job for this annotation

GitHub Actions / O2 linter

[doc/file] 

Documentation for \brief is missing, incorrect or misplaced.
#ifndef PWGCF_TWOPARTICLECORRELATIONS_TABLEPRODUCER_IDENTIFIEDBFFILTER_H_
#define PWGCF_TWOPARTICLECORRELATIONS_TABLEPRODUCER_IDENTIFIEDBFFILTER_H_

Expand All @@ -27,7 +27,7 @@
#include "Common/Core/TrackSelectionDefaults.h"
#include "PWGCF/Core/AnalysisConfigurableCuts.h"
#include "MathUtils/Utils.h"
#include <TDatabasePDG.h>

Check warning on line 30 in PWGCF/TwoParticleCorrelations/TableProducer/identifiedBfFilter.h

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/database] 

Direct use of TDatabasePDG is not allowed. Use o2::constants::physics::Mass... or Service<o2::framework::O2DatabasePDG>.

namespace o2
{
Expand Down Expand Up @@ -60,10 +60,10 @@
kWrongSpecies = -1
};

constexpr int pdgcodeEl = 11;

Check warning on line 63 in PWGCF/TwoParticleCorrelations/TableProducer/identifiedBfFilter.h

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid using hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
constexpr int pdgcodePi = 211;

Check warning on line 64 in PWGCF/TwoParticleCorrelations/TableProducer/identifiedBfFilter.h

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid using hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
constexpr int pdgcodeKa = 321;

Check warning on line 65 in PWGCF/TwoParticleCorrelations/TableProducer/identifiedBfFilter.h

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid using hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
constexpr int pdgcodePr = 2212;

Check warning on line 66 in PWGCF/TwoParticleCorrelations/TableProducer/identifiedBfFilter.h

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid using hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.

/// \enum SpeciesPairMatch
/// \brief The species pair considered by the matching test
Expand All @@ -85,9 +85,9 @@
kIdBfProtonProton ///< Proton-Proton
};

const char* speciesName[kIdBfNoOfSpecies+1] = {"e", "pi", "ka", "p","ha"};
const char* speciesName[kIdBfNoOfSpecies + 1] = {"e", "pi", "ka", "p", "ha"};

const char* speciesTitle[kIdBfNoOfSpecies+1] = {"e", "#pi", "K", "p","ha"};
const char* speciesTitle[kIdBfNoOfSpecies + 1] = {"e", "#pi", "K", "p", "ha"};

const int speciesChargeValue1[kIdBfNoOfSpecies] = {
0, //< electron
Expand Down Expand Up @@ -237,7 +237,7 @@
float particleMaxDCAZ = 999.9f;
bool traceCollId0 = false;

TDatabasePDG* fPDG = nullptr;

Check warning on line 240 in PWGCF/TwoParticleCorrelations/TableProducer/identifiedBfFilter.h

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/database] 

Direct use of TDatabasePDG is not allowed. Use o2::constants::physics::Mass... or Service<o2::framework::O2DatabasePDG>.

inline TriggerSelectionType getTriggerSelection(std::string const& triggstr)
{
Expand Down Expand Up @@ -710,7 +710,7 @@
if (useOwnTrackSelection) {
return ownTrackSelection.IsSelected(track);
} else {
for (auto filter : trackFilters) {

Check warning on line 713 in PWGCF/TwoParticleCorrelations/TableProducer/identifiedBfFilter.h

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (filter->IsSelected(track)) {
if (dca2Dcut) {
if (track.dcaXY() * track.dcaXY() / maxDCAxy / maxDCAxy + track.dcaZ() * track.dcaZ() / maxDCAz / maxDCAz > 1) {
Expand All @@ -727,8 +727,6 @@
}
}



/// \brief Accepts or not the passed track
/// \param track the track of interest
/// \return the internal track id, -1 if not accepted
Expand All @@ -740,7 +738,7 @@
template <typename ParticleObject, typename MCCollisionObject>
void exploreMothers(ParticleObject& particle, MCCollisionObject& collision)
{
for (auto& m : particle.template mothers_as<aod::McParticles>()) {

Check warning on line 741 in PWGCF/TwoParticleCorrelations/TableProducer/identifiedBfFilter.h

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
LOGF(info, " mother index: %d", m.globalIndex());
LOGF(info, " Tracking back mother");
LOGF(info, " assigned collision Id: %d, looping on collision Id: %d", m.mcCollisionId(), collision.globalIndex());
Expand Down
Loading