Request for comment: System.Text.Json compatibility #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated to .netstandard 2.0 for cityjson - Added small fix for net48 compatiblity in cj2glb.csproj - Note: cj2glb is not compatible with net48 because of signing issues with SharpGLTF and AnyOf (SharpGLTF is signed, AnyOf is not), but the code on this project's side is fully compatible if built against a locally checked out Gltf project
System.Text.JSON behaves a bit differently and does not allow global overrides, so deserialization should be done with CityJsonSystemTextJson.Options. All tests run completely, but there might be other trouble.
Owner
|
yes interested in this, I shall add a basic benchmark test so we can do a comparison |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since cityjson files tend to be huge and system.text.json promises to be more performant in many places, here's a refactor of the code that uses system.text.json.
At this point, all unit tests run ok, but there are breaking changes in the api or usage.
Most prominently:
TODO:
So the main question: is System.Text.Json interesting to you as well? There were also other clear reasons, upstream or downstream, to choose Newtonsoft.Json over stj.
Happy holidays!