Skip to content

Respect TCP_MAX_PACKET_SIZE while reading response body #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benoitc merged 1 commit into from
Jul 29, 2025
Merged

Respect TCP_MAX_PACKET_SIZE while reading response body #774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/hackney_response.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@
close/1,
expect_response/1]).

% The Erlang VM port forbids receiving TCP packets larger than 64MB
% https://github.com/erlang/otp/blob/359e254aba76c1986b671b45fd320c6cc6720ca8/erts/emulator/drivers/common/inet_drv.c#L1297
-define(MAX_PACKET_SIZE, 64 * 1024 * 1024).

%% internal
%% @doc Start the response It parse the request lines and headers.
start_response(#client{response_state=stream, mp_boundary=nil} = Client) ->
Expand Down Expand Up @@ -366,7 +370,7 @@ recv(#client{transport=Transport, socket=Skt, recv_timeout=Timeout}) ->
recv(#client{transport=Transport, socket=Skt, recv_timeout=Timeout}, {_BufSize, undefined}) ->
Transport:recv(Skt, 0, Timeout);
recv(#client{transport=Transport, socket=Skt, recv_timeout=Timeout}, {BufSize, ExpectedSize}) when ExpectedSize >= BufSize ->
Transport:recv(Skt, ExpectedSize - BufSize, Timeout);
Transport:recv(Skt, min(ExpectedSize - BufSize, ?MAX_PACKET_SIZE), Timeout);
recv(#client{transport=Transport, socket=Skt, recv_timeout=Timeout}, {_BufSize, _ExpectedSize}) ->
Transport:recv(Skt, 0, Timeout).

Expand Down