fix: create snapshot of configurations to prevent ConcurrentModificationException #979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionException When iterating over configurations using `matching()` or accessing `buildscript.configurations`, the returned collection is a live view that reflects changes to the underlying ConfigurationContainer. With Gradle 9.x and AGP 9.x, configurations are created lazily during dependency resolution. This causes ConcurrentModificationException when the `dependencyUpdates` task iterates over configurations while resolution triggers lazy creation of new configurations. The fix adds `.toSet()` to create a snapshot before iteration, ensuring the collection remains stable during the resolution process. Fixes ben-manes#966
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
ConcurrentModificationExceptionthat occurs when runningdependencyUpdateswith Gradle 9.x and AGP 9.x.Root Cause
When iterating over configurations using
matching()or accessingbuildscript.configurations, the returned collection is a live view that reflects changes to the underlyingConfigurationContainer.With Gradle 9.x and AGP 9.x, configurations are created lazily during dependency resolution. This causes
ConcurrentModificationExceptionwhen thedependencyUpdatestask iterates over configurations while resolution triggers lazy creation of new configurations.The Fix
Add
.toSet()to create a snapshot before iteration:Testing
Tested successfully with:
Related Issues
Fixes #966
Related to #968 (configuration cache compatibility - separate issue)
🤖 Generated with Claude Code